From be52613c12dfe357f38b763f547ca200cebdb488 Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Mon, 26 Aug 2024 14:13:52 -0400 Subject: [PATCH] QueryParser: Unsupported value type conversion should not KDL. Enhance the warning message and return a more relevant error code. Fixes #19017. Change-Id: I13d01ce206a27e5c9a35debc8081219422bfb10a Reviewed-on: https://review.haiku-os.org/c/haiku/+/8136 Reviewed-by: waddlesplash --- headers/private/file_systems/QueryParser.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/headers/private/file_systems/QueryParser.h b/headers/private/file_systems/QueryParser.h index 7c5fcc70f6..cf17090fa6 100644 --- a/headers/private/file_systems/QueryParser.h +++ b/headers/private/file_systems/QueryParser.h @@ -630,10 +630,9 @@ Equation::ConvertValue(type_code type) fSize = sizeof(double); break; default: - QUERY_FATAL("query value conversion to 0x%x requested!\n", - (int)type); - // should we fail here or just do a safety int32 conversion? - return B_ERROR; + QUERY_INFORM("query attribute '%s': unsupported value conversion to 0x%x requested!\n", + fAttribute, (int)type); + return B_BAD_TYPE; } fType = type;