i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix MIME type creation error

Browse Source 
DatabaseLocation::OpenOrCreateType(): BNode::WriteAttr() returns the
number of bytes written, not just an error code., so we erroneously
reported an error on success.

Fixes the first part of #9845.
This commit is contained in:
Ingo Weinhold
2013-07-01 14:17:51 +02:00
parent 4f82f6fa72
commit c09ec54a59
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/storage/mime/DatabaseLocation.cpp
+8 -2
View File
@@ -114,8 +114,14 @@ DatabaseLocation::OpenOrCreateType(const char* type, BNode& _node,
return error; return error;
// write the type attribute // write the type attribute
error = _node.WriteAttr(kTypeAttr, B_STRING_TYPE, 0, type, size_t toWrite = strlen(type) + 1;
strlen(type) + 1); ssize_t bytesWritten = _node.WriteAttr(kTypeAttr, B_STRING_TYPE, 0, type,
toWrite);
if (bytesWritten < 0)
error = bytesWritten;
else if ((size_t)bytesWritten != toWrite)
error = B_FILE_ERROR;
if (error != B_OK) { if (error != B_OK) {
_node.Unset(); _node.Unset();
return error; return error;