From c2d6b9fa8ee19bb8a505f294315cc649feed33c7 Mon Sep 17 00:00:00 2001 From: Rene Gollent Date: Sun, 30 Jun 2013 13:42:46 -0400 Subject: [PATCH] Reduce flickering in VariablesView. Since the individual _AddNode() invocations notify their node additions, NotifyTableModelReset() isn't really appropriate here after all, since the net effect will be seeing all the nodes getting added, then removed again, then re-added. Also fixes the fact that the variables wouldn't get cleared when picking Run, until we stopped again. --- .../user_interface/gui/team_window/VariablesView.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp b/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp index b31f8250ca..2e01387671 100644 --- a/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp +++ b/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp @@ -940,10 +940,10 @@ VariablesView::VariableTableModel::SetStackFrame(Thread* thread, fNodes.MakeEmpty(); } - if (stackFrame == NULL) { - NotifyNodesRemoved(TreeTablePath(), 0, count); + NotifyNodesRemoved(TreeTablePath(), 0, count); + + if (stackFrame == NULL) return; - } ValueNodeContainer* container = fNodeManager->GetContainer(); AutoLocker containerLocker(container); @@ -956,8 +956,6 @@ VariablesView::VariableTableModel::SetStackFrame(Thread* thread, // so those won't invoke our callback hook. Add them directly here. ValueNodeChildrenCreated(child->Node()); } - - NotifyTableModelReset(); }