SoftwareUpdater: Make the checkmark label less technical

Change-Id: Iff0eb78878189d033e4849f3994f34d5523530d6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10852
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>

src/apps/softwareupdater/SoftwareUpdaterWindow.cpp

@@ -725,10 +725,10 @@ SoftwareUpdaterWindow::_ShowSettingsDialog()
 {
 	BWindow* window = new BWindow(BRect(Frame().left + 50, Frame().top + 50, 0, 0),
 		B_TRANSLATE("Settings"), B_FLOATING_WINDOW,
-		B_AUTO_UPDATE_SIZE_LIMITS | B_NOT_ZOOMABLE | B_NOT_RESIZABLE);
+		B_AUTO_UPDATE_SIZE_LIMITS | B_NOT_ZOOMABLE | B_NOT_RESIZABLE | B_CLOSE_ON_ESCAPE);
 
 	BCheckBox* autoCleanUp = new BCheckBox(B_TRANSLATE(
-		"Automatically clean up administrative directory"));
+		"Automatically clean up old install states"));
 	autoCleanUp->SetValue(fAutoCleanUpAdminDirectory);
 	autoCleanUp->SetMessage(new BMessage(kSettingMsgAutoCleanUp));
 	autoCleanUp->SetTarget(this);

src/apps/softwareupdater/UpdateManager.cpp

@@ -406,10 +406,9 @@ UpdateManager::ProgressApplyingChangesDone(InstalledRepository& repository)
 			BJobStateListener listener;
 			BContext context(decisionProvider, listener);
 
-			const int days = 30;
+			time_t before = time(NULL) - kCleanUpKeepDays * 24 * 60 * 60;
-			time_t before = time(NULL) - days * 24 * 60 * 60;
 
-			CleanUpAdminDirectoryRequest request(context, info, before, 10);
+			CleanUpAdminDirectoryRequest request(context, info, before, kCleanUpKeepStates);
 			request.Process();
 		}
 	}

src/apps/softwareupdater/constants.h

@@ -12,6 +12,9 @@
 #define kAppSignature "application/x-vnd.haiku-softwareupdater"
 #define kSettingsFilename "SoftwareUpdater_settings"
 
+static const size_t kCleanUpKeepDays = 30;
+static const size_t kCleanUpKeepStates = 10;
+
 enum {
 	ACTION_STEP_INIT = 0,
 	ACTION_STEP_START,