From c3427db7500a037a89a64f297f0892f0adf7b4a4 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Sat, 12 Dec 2020 16:18:35 +0900 Subject: [PATCH] audio/null: Fix null pointer dereference MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix possible null pointer dereference at line 350-354 when 'device' is NULL at line 347. Pointed out by cppcheck. Change-Id: I25a090172a0d17ef3cb1fe607f70a31e579d13b0 Reviewed-on: https://review.haiku-os.org/c/haiku/+/3498 Reviewed-by: Jérôme Duval --- src/add-ons/kernel/drivers/audio/null/null_multi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/add-ons/kernel/drivers/audio/null/null_multi.c b/src/add-ons/kernel/drivers/audio/null/null_multi.c index 02d2f95ff6..28e6956f26 100644 --- a/src/add-ons/kernel/drivers/audio/null/null_multi.c +++ b/src/add-ons/kernel/drivers/audio/null/null_multi.c @@ -344,7 +344,10 @@ buffer_force_stop(device_t* device) { dprintf("null_audio: %s\n" , __func__ ); - if (device && device->running) + if (device == NULL) + return B_ERROR; + + if (device->running) null_stop_hardware(device); delete_area(device->playback_stream.buffer_area);