From c9cccf232adc051314d082fbf1bbd38f475e2d1f Mon Sep 17 00:00:00 2001
From: Matthew Wilber <mwilber@nowhere.fake>
Date: Thu, 30 Oct 2003 12:32:25 +0000
Subject: [PATCH] Changed BBitmapStream to behave more like Be's implementation
 while still checking for bad input.

git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5211 a95241bf-73f2-0310-859d-f6bbb57e9c96
---
 src/kits/translation/BitmapStream.cpp | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/kits/translation/BitmapStream.cpp b/src/kits/translation/BitmapStream.cpp
index c6318249e1..a0d36052bf 100644
--- a/src/kits/translation/BitmapStream.cpp
+++ b/src/kits/translation/BitmapStream.cpp
@@ -131,12 +131,14 @@ BBitmapStream::~BBitmapStream()
 status_t
 BBitmapStream::ReadAt(off_t pos, void *buffer, size_t size)
 {
-	if (!buffer || pos < 0)
-		return B_BAD_VALUE;
-	if (!fBitmap || pos >= fSize)
+	if (!fBitmap)
 		return B_ERROR;
 	if (!size)
 		return B_NO_ERROR;
+	if (pos >= fSize)
+		return B_ERROR;
+	if (!buffer || pos < 0)
+		return B_BAD_VALUE;
 
 	size_t toRead;
 	void *source;
@@ -182,10 +184,10 @@ BBitmapStream::ReadAt(off_t pos, void *buffer, size_t size)
 status_t
 BBitmapStream::WriteAt(off_t pos, const void *data, size_t size)
 {
-	if (!data || pos < 0 || pos > fSize)
-		return B_BAD_VALUE;
 	if (!size)
 		return B_NO_ERROR;
+	if (!data || pos < 0 || pos > fSize)
+		return B_BAD_VALUE;
 
 	ssize_t written = 0;
 	while (size > 0) {
@@ -384,8 +386,10 @@ BBitmapStream::DetachBitmap(BBitmap **outBitmap)
 {
 	if (!outBitmap)
 		return B_BAD_VALUE;
-	if (fDetached || !fBitmap)
+	if (!fBitmap || fDetached) {
+		*outBitmap = NULL;
 		return B_ERROR;
+	}
 		
 	fDetached = true;
 	*outBitmap = fBitmap;