From cbf3fb528f6a7742bfed45a1e84feb0b47a561fb Mon Sep 17 00:00:00 2001
From: Murai Takashi <tmurai01@gmail.com>
Date: Mon, 20 Dec 2021 05:53:22 +0900
Subject: [PATCH] expander: Fix file descriptor leak

Pointed by Infer static analyser.

Change-Id: Iaf79d58a963976a8ee6f7313c3d1902ff50ecf9e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7258
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
---
 src/apps/expander/ExpanderThread.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/apps/expander/ExpanderThread.cpp b/src/apps/expander/ExpanderThread.cpp
index c93b826ef3..6ee078cb63 100644
--- a/src/apps/expander/ExpanderThread.cpp
+++ b/src/apps/expander/ExpanderThread.cpp
@@ -247,8 +247,10 @@ ExpanderThread::PipeCommand(int argc, const char** argv, int& in, int& out,
 		close(master);
 
 		setsid();
-		if (ioctl(slave, TIOCSCTTY, NULL) != 0)
+		if (ioctl(slave, TIOCSCTTY, NULL) != 0) {
+			close(slave);
 			return -1;
+		}
 
 		dup2(slave, 0);
 		close(slave);