Change BObjectList to take "owning" as a template parameter and adjust all consumers.

Since BObjectList is a template class, this only breaks ABI where
BObjectList was exposed in public methods, and even then it's only
a name mangling break and we should be able to add compatibility
methods if necessary.

(The old "bool owning" member variable is left intact for ABI
compatibility, for the moment, though it's otherwise unused now.)

Tracker's PoseList is the only remaining type that has a "bool owning"
switch in the constructor rather than template parameters.

This should significantly improve the output of static code analysis
tools that previously detected list operations as causing use-after-frees
and double-frees, as well as make code maintenance easier by making it
easier to determine what list owns (or does not own) an object.
It should also be a minor performance optimization, since the branches
for calls to delete/free should now be optimized out altogether.

Still boots to desktop and Tracker, Deskbar, Debugger all tested
and verified as working.

Change-Id: If2a24a6f0d22e7a506ef554fcfdd328907279ed4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8915
Reviewed-by: waddlesplash <[email protected]>

This commit is contained in:

Augustin Cavalier

2025-02-06 00:06:32 +00:00

committed by

waddlesplash

parent 007126ed6f

commit cbfbbf6d4d

247 changed files with 761 additions and 705 deletions

									
										headers/libs/linprog/Summand.h
									
		+1
		-1
	
												View File
												
				@@ -34,7 +34,7 @@ private:

							Variable*			fVar;

				};

				typedef BObjectList<Summand> SummandList;

				typedef BObjectList<Summand, true> SummandList;

				}	// namespace LinearProgramming