From cd00276153e13fe4597ecfad427f231521f3c706 Mon Sep 17 00:00:00 2001 From: Andrew Lindesay Date: Tue, 21 May 2019 21:57:02 +0200 Subject: [PATCH] HaikuDepot: Filtering Crash Resolution I am unable to reproduce the problem locally, but suspect that the lack of locking around one line may be the cause. Hopefully fixes #14025. Change-Id: I14ba6d2cb4f264af732fad9c783c55f690cece4f Reviewed-on: https://review.haiku-os.org/c/1472 Reviewed-by: waddlesplash --- src/apps/haikudepot/ui/MainWindow.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/apps/haikudepot/ui/MainWindow.cpp b/src/apps/haikudepot/ui/MainWindow.cpp index 022011ab4b..fb26b69ba0 100644 --- a/src/apps/haikudepot/ui/MainWindow.cpp +++ b/src/apps/haikudepot/ui/MainWindow.cpp @@ -817,10 +817,9 @@ MainWindow::_InitWorkerThreads() void MainWindow::_AdoptModel() { - fVisiblePackages = fModel.CreatePackageList(); - { AutoLocker modelLocker(fModel.Lock()); + fVisiblePackages = fModel.CreatePackageList(); AutoLocker listLocker(fPackagesToShowListLock); fPackagesToShowList = fVisiblePackages; atomic_add(&fPackagesToShowListID, 1);