From ce6f81f7b2e2a7ae4d0d7facbb5e69d804b6e356 Mon Sep 17 00:00:00 2001 From: Pawel Dziepak Date: Thu, 21 Mar 2013 02:46:04 +0100 Subject: [PATCH] nfs4: Fix CID 991503: memory leak in handling callback requests --- .../kernel/file_systems/nfs4/RPCCallbackServer.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/add-ons/kernel/file_systems/nfs4/RPCCallbackServer.cpp b/src/add-ons/kernel/file_systems/nfs4/RPCCallbackServer.cpp index c296289d84..fa371a0ffe 100644 --- a/src/add-ons/kernel/file_systems/nfs4/RPCCallbackServer.cpp +++ b/src/add-ons/kernel/file_systems/nfs4/RPCCallbackServer.cpp @@ -307,17 +307,17 @@ CallbackServer::ConnectionThread(ConnectionEntry* entry) } CallbackRequest* request = new CallbackRequest(buffer, size); - if (request == NULL || request->Error() != B_OK) { + if (request == NULL) { free(buffer); - continue; - } else if (request != NULL && request->Error() != B_OK) { + continue; + } else if (request->Error() != B_OK) { reply = CallbackReply::Create(request->XID(), request->RPCError()); if (reply != NULL) { connection->Send(reply->Stream().Buffer(), reply->Stream().Size()); delete reply; } - free(buffer); + delete request; continue; } @@ -335,7 +335,7 @@ CallbackServer::ConnectionThread(ConnectionEntry* entry) } default: - free(buffer); + delete request; } }