From ceb063d041bdb014a3d07b44eadf2ee389deb797 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samuel=20Rodr=C3=ADguez=20P=C3=A9rez?= Date: Fri, 14 Nov 2025 10:23:41 +0000 Subject: [PATCH] input preflet: Fix tap slider limit values + license update It was previously using spacing which seems to be a problem. Spacing value is 11 which by the code will end up on 22 and the default value is 20 making the tap slided to be very close to the end with the old code and might be different in case control looks or other external from the preflet UI changes in the future. To avoid that issue the limit has been put of a sensible value of 50 and divided on 11 marks to visually be divided in chunks of 10% sized regions. Change-Id: Ief7461474f0f37eb6fa4bdea1ef8004a531328df Reviewed-on: https://review.haiku-os.org/c/haiku/+/9901 Reviewed-by: nephele nephele --- src/preferences/input/InputTouchpadPref.cpp | 1 + src/preferences/input/InputTouchpadPrefView.cpp | 5 +++-- src/preferences/input/InputTouchpadPrefView.h | 5 +++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/preferences/input/InputTouchpadPref.cpp b/src/preferences/input/InputTouchpadPref.cpp index 46c2200ba4..6428f1c4b1 100644 --- a/src/preferences/input/InputTouchpadPref.cpp +++ b/src/preferences/input/InputTouchpadPref.cpp @@ -5,6 +5,7 @@ * Authors: * Preetpal Kaur * Pawan Yerramilli + * Samuel Rodríguez Pérez */ diff --git a/src/preferences/input/InputTouchpadPrefView.cpp b/src/preferences/input/InputTouchpadPrefView.cpp index f01d16c1c7..da2d51668d 100644 --- a/src/preferences/input/InputTouchpadPrefView.cpp +++ b/src/preferences/input/InputTouchpadPrefView.cpp @@ -5,6 +5,7 @@ * Authors: * Preetpal Kaur * Pawan Yerramilli + * Samuel Rodríguez Pérez */ @@ -470,9 +471,9 @@ TouchpadPrefView::SetupView() scrollPrefLayout->AddView(scrollPrefRightLayout); fTapSlider = new BSlider("tap_sens", B_TRANSLATE("Tapping sensitivity"), - new BMessage(TAP_CONTROL_CHANGED), 0, spacing * 2, B_HORIZONTAL); + new BMessage(TAP_CONTROL_CHANGED), 0, 50, B_HORIZONTAL); fTapSlider->SetHashMarks(B_HASH_MARKS_BOTTOM); - fTapSlider->SetHashMarkCount(7); + fTapSlider->SetHashMarkCount(11); fTapSlider->SetLimitLabels(B_TRANSLATE("Off"), B_TRANSLATE("High")); fSpeedSlider = new BSlider("pad_speed", B_TRANSLATE("Trackpad speed"), diff --git a/src/preferences/input/InputTouchpadPrefView.h b/src/preferences/input/InputTouchpadPrefView.h index aa81289ea9..1eb4c2c1ad 100644 --- a/src/preferences/input/InputTouchpadPrefView.h +++ b/src/preferences/input/InputTouchpadPrefView.h @@ -1,9 +1,10 @@ /* - * Copyright 2019, Haiku, Inc. + * Copyright 2019-2025, Haiku, Inc. * Distributed under the terms of the MIT License. * - * Author: + * Authors: * Preetpal Kaur + * Samuel Rodríguez Pérez */