i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid leaking a file descriptor on error. Thanks PovAddict for running cppcheck.

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40037 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
François Revol
2010-12-29 20:05:24 +00:00
parent 4517bee6c0
commit d074928c03
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/apps/debugger/files/SourceFile.cpp
+6 -2
View File
@@ -63,12 +63,16 @@ SourceFile::Init(const char* path)
return errno; return errno;
} }
if (st.st_size > kMaxSourceFileSize) if (st.st_size > kMaxSourceFileSize) {
close (fd);
return B_FILE_TOO_LARGE; return B_FILE_TOO_LARGE;
}
size_t fileSize = st.st_size; size_t fileSize = st.st_size;
if (fileSize == 0) if (fileSize == 0) {
close (fd);
return B_BAD_VALUE; return B_BAD_VALUE;
}
// allocate the content buffer // allocate the content buffer
fFileContent = (char*)malloc(fileSize + 1); fFileContent = (char*)malloc(fileSize + 1);