i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libroot_build: replace void* with addr_t for hidden functions.

Browse Source 
* Using attribute visibility hidden doesn't get applied if a
  function returns a non-class pointer type, so the functions
  weren't being hidden for gcc4+ builds, resulting in stack
  overflows. Using addr_t, which should be the same size as
  void* works around this restriction.
This commit is contained in:
Jessica Hamilton
2018-06-16 10:08:56 +00:00
parent 64d4515abf
commit d284524815
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/build/libroot/function_remapper.cpp
+8 -8
View File
@@ -282,30 +282,30 @@ renameat(int fromFD, const char* from, int toFD, const char* to)
// fs_attr_* functions only need to be remapped on Haiku // fs_attr_* functions only need to be remapped on Haiku
extern "C" void* HIDDEN_FUNCTION_ATTRIBUTE extern "C" addr_t HIDDEN_FUNCTION_ATTRIBUTE
fs_open_attr_dir(const char *path) fs_open_attr_dir(const char *path)
{ {
HIDDEN_FUNCTION(fs_open_attr_dir); HIDDEN_FUNCTION(fs_open_attr_dir);
return _haiku_build_fs_open_attr_dir(path); return (addr_t)_haiku_build_fs_open_attr_dir(path);
} }
extern "C" void* HIDDEN_FUNCTION_ATTRIBUTE extern "C" addr_t HIDDEN_FUNCTION_ATTRIBUTE
fs_lopen_attr_dir(const char *path) fs_lopen_attr_dir(const char *path)
{ {
HIDDEN_FUNCTION(fs_lopen_attr_dir); HIDDEN_FUNCTION(fs_lopen_attr_dir);
return _haiku_build_fs_lopen_attr_dir(path); return (addr_t)_haiku_build_fs_lopen_attr_dir(path);
} }
extern "C" void* HIDDEN_FUNCTION_ATTRIBUTE extern "C" addr_t HIDDEN_FUNCTION_ATTRIBUTE
fs_fopen_attr_dir(int fd) fs_fopen_attr_dir(int fd)
{ {
HIDDEN_FUNCTION(fs_fopen_attr_dir); HIDDEN_FUNCTION(fs_fopen_attr_dir);
return _haiku_build_fs_fopen_attr_dir(fd); return (addr_t)_haiku_build_fs_fopen_attr_dir(fd);
} }
@@ -318,12 +318,12 @@ fs_close_attr_dir(void *dir)
} }
extern "C" void* HIDDEN_FUNCTION_ATTRIBUTE extern "C" addr_t HIDDEN_FUNCTION_ATTRIBUTE
fs_read_attr_dir(void *dir) fs_read_attr_dir(void *dir)
{ {
HIDDEN_FUNCTION(fs_read_attr_dir); HIDDEN_FUNCTION(fs_read_attr_dir);
return _haiku_build_fs_read_attr_dir(dir); return (addr_t)_haiku_build_fs_read_attr_dir(dir);
} }