From d28b9f6540555e7a66ee484553a657bad8f2ae9a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= <superstippi@gmx.de>
Date: Fri, 11 Nov 2005 00:10:03 +0000
Subject: [PATCH] * disable caching of the clipping region,   there can be no
 notification when it changes in the server.   Note that GetClippingRegion()
 gets the actually effective clipping,   not only the user defined clipping. *
 when removing ourself, set the last mouse moved view of the parent   window
 to NULL in case it was pointing to this view * round the frame rectangle
 passed to the constructor, I have not   actually compared this with R5
 behaviour though.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14844 a95241bf-73f2-0310-859d-f6bbb57e9c96
---
 src/kits/interface/View.cpp | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/src/kits/interface/View.cpp b/src/kits/interface/View.cpp
index 7c33e4899b..4fe0528892 100644
--- a/src/kits/interface/View.cpp
+++ b/src/kits/interface/View.cpp
@@ -2154,14 +2154,11 @@ BView::GetClippingRegion(BRegion* region) const
 	if (!region)
 		return;
 
-	// TODO: I think this implementation is wrong,
-	// since on R5, you really get the currently active
-	// clipping region, overlapping windows and all.
-	// I don't think we inform the client in the app_server
-	// when the clipping changes, so that B_VIEW_CLIP_REGION_BIT
-	// is set. -Stephan
+	// TODO: For now, the clipping bit is ignored, since the client has no
+	// idea when the clipping in the server changed. -Stephan
 
-	if (!fState->IsValid(B_VIEW_CLIP_REGION_BIT) && do_owner_check()) {
+//	if (!fState->IsValid(B_VIEW_CLIP_REGION_BIT) && fOwner && do_owner_check()) {
+	if (fOwner && do_owner_check()) {
 		fOwner->fLink->StartMessage(AS_LAYER_GET_CLIP_REGION);
 
  		int32 code;
@@ -2180,6 +2177,8 @@ BView::GetClippingRegion(BRegion* region) const
 			}
 			fState->valid_flags |= B_VIEW_CLIP_REGION_BIT;
 		}
+	} else {
+		fState->clipping_region.MakeEmpty();
 	}
 
 	*region = fState->clipping_region;
@@ -3387,6 +3386,9 @@ BView::RemoveSelf()
 		if (fOwner->fKeyMenuBar == this)
 			fOwner->fKeyMenuBar = NULL;
 
+		if (fOwner->fLastMouseMovedView == this)
+			fOwner->fLastMouseMovedView = NULL;
+
 		if (fOwner->fLastViewToken == _get_object_token_(this))
 			fOwner->fLastViewToken = B_NULL_TOKEN;
 
@@ -3745,6 +3747,12 @@ BView::InitData(BRect frame, const char *name, uint32 resizingMode, uint32 flags
 	// initialize members		
 	fFlags = (resizingMode & _RESIZE_MASK_) | (flags & ~_RESIZE_MASK_);
 
+	// handle rounding
+	frame.left = roundf(frame.left);
+	frame.top = roundf(frame.top);
+	frame.right = roundf(frame.right);
+	frame.bottom = roundf(frame.bottom);
+
 	fParentOffset.Set(frame.left, frame.top);
 
 	fOwner = NULL;