From d54c477ad18cac663d4c135007985c051f571679 Mon Sep 17 00:00:00 2001 From: stippi Date: Wed, 24 Feb 2010 10:34:53 +0000 Subject: [PATCH] Properly set the download listener on new tabs. This fixes the Downloads window not popping up for subsequent tabs. git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@192 94f232f2-1747-11df-bad5-a5bfde151594 --- src/apps/webpositive/LauncherWindow.cpp | 4 +++- src/apps/webpositive/LauncherWindow.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/apps/webpositive/LauncherWindow.cpp b/src/apps/webpositive/LauncherWindow.cpp index b721e8d313..5fc38abc75 100644 --- a/src/apps/webpositive/LauncherWindow.cpp +++ b/src/apps/webpositive/LauncherWindow.cpp @@ -94,6 +94,7 @@ LauncherWindow::LauncherWindow(BRect frame, const BMessenger& downloadListener, : WebViewWindow(frame, "HaikuLauncher", B_TITLED_WINDOW_LOOK, B_NORMAL_WINDOW_FEEL, B_AUTO_UPDATE_SIZE_LIMITS | B_ASYNCHRONOUS_CONTROLS) + , m_downloadListener(downloadListener) { m_tabView = new WebTabView("tabview", BMessenger(this)); m_tabView->setTarget(BMessenger(this)); @@ -228,7 +229,6 @@ LauncherWindow::LauncherWindow(BRect frame, const BMessenger& downloadListener, } newTab("", true); - currentWebView()->WebPage()->SetDownloadListener(downloadListener); m_findGroup->SetVisible(false); @@ -410,6 +410,8 @@ void LauncherWindow::newTab(const BString& url, bool select) { // Executed in app thread (new BWebPage needs to be created in app thread). BWebView* webView = new BWebView("web_view"); + webView->WebPage()->SetDownloadListener(m_downloadListener); + m_tabView->AddTab(webView); m_tabView->TabAt(m_tabView->CountTabs() - 1)->SetLabel("New tab"); // TODO: Remove when BTabView is fixed... diff --git a/src/apps/webpositive/LauncherWindow.h b/src/apps/webpositive/LauncherWindow.h index f1879290fa..d0f8fe0a2c 100644 --- a/src/apps/webpositive/LauncherWindow.h +++ b/src/apps/webpositive/LauncherWindow.h @@ -31,6 +31,7 @@ #define LauncherWindow_h #include "WebViewWindow.h" +#include #include class BButton; @@ -92,6 +93,7 @@ private: void updateTitle(const BString &title); private: + BMessenger m_downloadListener; BMenuBar* m_menuBar; BMenu* m_goMenu; IconButton* m_BackButton;