i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* LockBits() now returns B_OK for non-overlay bitmaps, as that makes much more sense.

Browse Source 
* Added TODO about the possible use of the state parameter (would be nice to be compatible
  with R5 here, of course).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21510 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler
2007-06-26 23:20:44 +00:00
parent eeb608e1c7
commit d56eb9cf5d
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/interface/Bitmap.cpp
+5 -2
View File
@@ -409,6 +409,9 @@ BBitmap::IsValid() const
status_t status_t
BBitmap::LockBits(uint32 *state) BBitmap::LockBits(uint32 *state)
{ {
// TODO: how do we fill the "state"?
// It would be more or less useful to report what kind of bitmap
// we got (ie. overlay, placeholder, or non-overlay)
if (fFlags & B_BITMAP_WILL_OVERLAY) { if (fFlags & B_BITMAP_WILL_OVERLAY) {
overlay_client_data* data = (overlay_client_data*)fBasePointer; overlay_client_data* data = (overlay_client_data*)fBasePointer;
@@ -424,7 +427,7 @@ BBitmap::LockBits(uint32 *state)
// drawing the bitmap yet? // drawing the bitmap yet?
// axeld: you mean for non overlays? // axeld: you mean for non overlays?
return B_ERROR; return B_OK;
} }
@@ -442,7 +445,7 @@ BBitmap::UnlockBits()
release_sem(data->lock); release_sem(data->lock);
} }
// Area
/*! \brief Returns the ID of the area the bitmap data reside in. /*! \brief Returns the ID of the area the bitmap data reside in.
\return The ID of the area the bitmap data reside in. \return The ID of the area the bitmap data reside in.
*/ */