From d8bca3564a070cf355d4cbce87085a19993d158d Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Sat, 23 Sep 2023 17:05:19 -0400 Subject: [PATCH] Tracker: Check whether the default button is disabled on double-click. The comment above this block specified the correct behavior: the button's status is already updated elsewhere, so just check IsEnabled(). But the code did not actually do that. It appears this has been incorrect all the way back to the initial OpenTracker import in 2001. Fixes #13721. --- src/kits/tracker/FilePanelPriv.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kits/tracker/FilePanelPriv.cpp b/src/kits/tracker/FilePanelPriv.cpp index 9eb1f7465c..47ff09bd2f 100644 --- a/src/kits/tracker/FilePanelPriv.cpp +++ b/src/kits/tracker/FilePanelPriv.cpp @@ -1261,7 +1261,7 @@ TFilePanel::MessageReceived(BMessage* message) // all we have to do is see if the button is enabled. BButton* button = dynamic_cast( FindView("default button")); - if (button == NULL) + if (button == NULL || !button->IsEnabled()) break; if (IsSavePanel()) {