i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BufferCache: More strict validity checks

Browse Source 
* This add a debugger call if the BBuffer id is
mismatched at object creation.
This commit is contained in:
Dario Casalinuovo
2015-11-28 16:35:05 +01:00
parent 67060664c9
commit d98b8c7c59
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/media/BufferCache.cpp
+5 -1
View File
@@ -45,11 +45,15 @@ BufferCache::GetBuffer(media_buffer_id id)
buffer_clone_info info; buffer_clone_info info;
info.buffer = id; info.buffer = id;
BBuffer* buffer = new(std::nothrow) BBuffer(info); BBuffer* buffer = new(std::nothrow) BBuffer(info);
if (buffer == NULL || buffer->Data() == NULL) { if (buffer == NULL || buffer->ID() <= 0
|| buffer->Data() == NULL) {
delete buffer; delete buffer;
return NULL; return NULL;
} }
if (buffer->ID() != id)
debugger("BufferCache::GetBuffer: IDs mismatch");
try { try {
fMap.insert(std::make_pair(id, buffer)); fMap.insert(std::make_pair(id, buffer));
} catch (std::bad_alloc& exception) { } catch (std::bad_alloc& exception) {