From d98fcb7db67a4103db3ceec8c3a83bf003932a2a Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Tue, 3 May 2022 16:59:19 -0400 Subject: [PATCH] HID: Return ENODEV instead of B_ERROR if the device was removed. This should help with diagnosing problems in some failure conditions. --- src/add-ons/kernel/drivers/input/i2c_hid/HIDDevice.cpp | 2 +- src/add-ons/kernel/drivers/input/usb_hid/HIDDevice.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/add-ons/kernel/drivers/input/i2c_hid/HIDDevice.cpp b/src/add-ons/kernel/drivers/input/i2c_hid/HIDDevice.cpp index 3b080b7a85..42c91a2176 100644 --- a/src/add-ons/kernel/drivers/input/i2c_hid/HIDDevice.cpp +++ b/src/add-ons/kernel/drivers/input/i2c_hid/HIDDevice.cpp @@ -163,7 +163,7 @@ status_t HIDDevice::MaybeScheduleTransfer(HIDReport *report) { if (fRemoved) - return B_ERROR; + return ENODEV; if (atomic_get_and_set(&fTransferScheduled, 1) != 0) { // someone else already caused a transfer to be scheduled diff --git a/src/add-ons/kernel/drivers/input/usb_hid/HIDDevice.cpp b/src/add-ons/kernel/drivers/input/usb_hid/HIDDevice.cpp index e0304c3497..cbce1e65ee 100644 --- a/src/add-ons/kernel/drivers/input/usb_hid/HIDDevice.cpp +++ b/src/add-ons/kernel/drivers/input/usb_hid/HIDDevice.cpp @@ -266,7 +266,7 @@ status_t HIDDevice::MaybeScheduleTransfer(HIDReport*) { if (fRemoved) - return B_ERROR; + return ENODEV; if (atomic_get_and_set(&fTransferScheduled, 1) != 0) { // someone else already caused a transfer to be scheduled