i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

DataRequest: Don't leak buffer in error case. CID 1162796

Browse Source
This commit is contained in:
Stephan Aßmus
2014-01-22 17:41:52 +01:00
parent 59246cf737
commit dae0b385cf
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/network/libnetapi/DataRequest.cpp
+4 -1
View File
@@ -90,8 +90,11 @@ BDataRequest::_ProtocolLoop()
// There may be some padding at the end of the base64 stream. This // There may be some padding at the end of the base64 stream. This
// prevents us from computing the exact length we should get, so allow // prevents us from computing the exact length we should get, so allow
// for some error margin. // for some error margin.
if(length > data.Length() * 4 / 3 || length < data.Length() * 4 / 3 - 3) if(length > data.Length() * 4 / 3
|| length < data.Length() * 4 / 3 - 3) {
delete[] buffer;
return B_BAD_DATA; return B_BAD_DATA;
}
} else { } else {
payload = data.String(); payload = data.String();
length = data.Length(); length = data.Length();