i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tracker (FSUtils): negative passed to unsigned parameter

Browse Source 
BVolume::BlockSize() might return a negative value (error code) and it
was passed as parameter of CalcItemsAndSize() as a size_t (unsigned).

Thus the check for an error code failed.

CID 4171.
This commit is contained in:
Philippe Saint-Pierre
2012-01-04 19:31:17 -05:00
parent aa11dcae4d
commit dafbb16406
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/tracker/FSUtils.cpp
+2 -2
View File
@@ -115,7 +115,7 @@ static status_t MoveTask(BObjectList<entry_ref> *, BEntry *, BList *, uint32);
static status_t _DeleteTask(BObjectList<entry_ref> *, bool); static status_t _DeleteTask(BObjectList<entry_ref> *, bool);
static status_t _RestoreTask(BObjectList<entry_ref> *); static status_t _RestoreTask(BObjectList<entry_ref> *);
status_t CalcItemsAndSize(CopyLoopControl* loopControl, status_t CalcItemsAndSize(CopyLoopControl* loopControl,
BObjectList<entry_ref> *refList, size_t blockSize, int32 *totalCount, BObjectList<entry_ref> *refList, ssize_t blockSize, int32 *totalCount,
off_t *totalSize); off_t *totalSize);
status_t MoveItem(BEntry *entry, BDirectory *destDir, BPoint *loc, status_t MoveItem(BEntry *entry, BDirectory *destDir, BPoint *loc,
uint32 moveMode, const char *newName, Undo &undo, uint32 moveMode, const char *newName, Undo &undo,
@@ -2391,7 +2391,7 @@ FSRecursiveCalcSize(BInfoWindow* window, CopyLoopControl* loopControl,
status_t status_t
CalcItemsAndSize(CopyLoopControl* loopControl, BObjectList<entry_ref> *refList, CalcItemsAndSize(CopyLoopControl* loopControl, BObjectList<entry_ref> *refList,
size_t blockSize, int32 *totalCount, off_t *totalSize) ssize_t blockSize, int32 *totalCount, off_t *totalSize)
{ {
int32 fileCount = 0; int32 fileCount = 0;
int32 dirCount = 0; int32 dirCount = 0;