From db9fbf8e9d2c4f6896a33eaacf5fed70bf9295bf Mon Sep 17 00:00:00 2001 From: Ryan Leavengood Date: Sat, 30 Dec 2006 17:50:48 +0000 Subject: [PATCH] Changed the new menu item's text to be more user friendly, thanks to DarkWyrm. Added a Japanese translation for this item, thanks to Koki. Now the old queries are deleted before adding new ones, thanks to AGMS. Though the last item was not actually a memory leak (the destructor would eventually get all the added queries), this would cause weird behavior which I did notice (multiple queries existed which all sent the same notifications.) Either way, good catch AGMS :) git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19657 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/servers/mail/deskbarview.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/servers/mail/deskbarview.cpp b/src/servers/mail/deskbarview.cpp index d2b9c710ed..6f95c5bded 100644 --- a/src/servers/mail/deskbarview.cpp +++ b/src/servers/mail/deskbarview.cpp @@ -113,6 +113,10 @@ void DeskbarView::AttachedToWindow() void DeskbarView::RefreshMailQuery() { + for (int32 i = 0; i < fNewMailQueries.CountItems(); i++) + delete ((BQuery *)(fNewMailQueries.ItemAt(i))); + fNewMailQueries.MakeEmpty(); + BVolumeRoster volumes; BVolume volume; fNewMessages = 0; @@ -478,7 +482,9 @@ DeskbarView::BuildMenu() // Hack for R5's buggy Query Notification #ifdef HAIKU_TARGET_PLATFORM_BEOS - menu->AddItem(new BMenuItem("Refresh New Mail Query", + menu->AddItem(new BMenuItem( + MDR_DIALECT_CHOICE("Refresh New Mail Count", + "未読メールカウントを更新"), new BMessage(MD_REFRESH_QUERY))); #endif