i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix problems unwinding call frames.

Browse Source 
Our more recent build of gcc4 appears to have switched to using
.eh_frame for almost all useful call frame information when built
with debugging. Use a somewhat crude heuristic (size) to determine
if the .debug_frame section we've been given might actually be of use
or not (assuming it exists at all, this was inconsistent in my tests.
Sometimes apps had no .debug_frame at all, other times it was present
but was only roundabouts 100 bytes).

Fixes ticket #8508.
This commit is contained in:
Rene Gollent
2012-05-28 15:39:38 -04:00
parent e0a6e07bb3
commit dbf07c84a2
1 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/apps/debugger/dwarf/DwarfFile.cpp
+18 -8
View File
@@ -350,15 +350,25 @@ DwarfFile::Load(const char* fileName)
fDebugRangesSection = fElfFile->GetSection(".debug_ranges"); fDebugRangesSection = fElfFile->GetSection(".debug_ranges");
fDebugLineSection = fElfFile->GetSection(".debug_line"); fDebugLineSection = fElfFile->GetSection(".debug_line");
fDebugFrameSection = fElfFile->GetSection(".debug_frame"); fDebugFrameSection = fElfFile->GetSection(".debug_frame");
if (fDebugFrameSection == NULL) { ElfSection* ehFrameSection = fElfFile->GetSection(".eh_frame");
fDebugFrameSection = fElfFile->GetSection(".eh_frame"); if (fDebugFrameSection != NULL) {
fUsingEHFrameSection = fDebugFrameSection != NULL; if (ehFrameSection != NULL && ehFrameSection->Size()
if (fUsingEHFrameSection) { > fDebugFrameSection->Size()) {
fGCC4EHFrameSection = !fDebugFrameSection->IsWritable(); fElfFile->PutSection(fDebugFrameSection);
// Crude heuristic for recognizing GCC 4 (Itanium ABI) style fDebugFrameSection = ehFrameSection;
// .eh_frame sections. The ones generated by GCC 2 are writable, fUsingEHFrameSection = true;
// the ones generated by GCC 4 aren't.
} }
} else if (ehFrameSection != NULL) {
fDebugFrameSection = ehFrameSection;
fUsingEHFrameSection = true;
}
if (fUsingEHFrameSection) {
fGCC4EHFrameSection = !fDebugFrameSection->IsWritable();
// Crude heuristic for recognizing GCC 4 (Itanium ABI) style
// .eh_frame sections. The ones generated by GCC 2 are writable,
// the ones generated by GCC 4 aren't.
} }
fDebugLocationSection = fElfFile->GetSection(".debug_loc"); fDebugLocationSection = fElfFile->GetSection(".debug_loc");
fDebugPublicTypesSection = fElfFile->GetSection(".debug_pubtypes"); fDebugPublicTypesSection = fElfFile->GetSection(".debug_pubtypes");