Renamed BAppServerLink to AppServerLink, BPortLink to PortLink, LinkMsgReader

to LinkReceiver, LinkMsgSender to LinkSender, and put everything into the
BPrivate namespace.
Made AppServerLink a cheap object - it will use the applications receiver/sender
and not create its own buffers.
Fixed broken communication stuff here and there (mostly Font.cpp).
Put the newly introduced set|get_system_colors() into the BPrivate namespace -
please don't introduce private functions into the public namespace!!!
Also fixed their broken communication use, as Darkwyrm obviously forgot about
it again: the sequence Flush(); GetNextMessage() without error checking is
purely wrong and can make the app hang and/or crash! :-)
Other minor cleanup.
The input_server used some test mode with the haiku build target which is
probably wrong.
Hopefully I did not forget anything this time.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13128 a95241bf-73f2-0310-859d-f6bbb57e9c96

headers/os/interface/Region.h

@@ -15,21 +15,24 @@
 #include <BeBuild.h>
 #include <Rect.h>
 
+namespace BPrivate {
+	class ServerLink;
+};
+
+
 /* Integer rect used to define a cliping rectangle. All bounds are included */
 /* Moved from DirectWindow.h */
 typedef struct {
-	int32		left;
-	int32		top;
-	int32		right;
-	int32		bottom;
+	int32	left;
+	int32	top;
+	int32	right;
+	int32	bottom;
 } clipping_rect;
 
 
-/*----------------------------------------------------------------*/
 /*----- BRegion class --------------------------------------------*/
 
 class BRegion {
-
 public:
 				BRegion();
 				BRegion(const BRegion &region);
@@ -64,11 +67,10 @@ clipping_rect	RectAtInt(int32 index);
 		class Support;
 
 private:
-
-friend class BView;
-friend class BDirectWindow;
-friend class Support;
-friend class BPortLink;
+	friend class BView;
+	friend class BDirectWindow;
+	friend class Support;
+	friend class BPrivate::ServerLink;
 
 		void	_AddRect(clipping_rect r);
 		void	set_size(long new_size);
@@ -80,7 +82,4 @@ private:
 		clipping_rect	*data;
 };
 
-/*-------------------------------------------------------------*/
-/*-------------------------------------------------------------*/
-
 #endif /* _REGION_H */

headers/os/interface/Shape.h

@@ -14,6 +14,11 @@
 #include <BeBuild.h>
 #include <Archivable.h>
 
+namespace BPrivate {
+	class ServerLink;
+};
+
+
 /*----------------------------------------------------------------*/
 /*----- BShapeIterator class -------------------------------------*/
 
@@ -78,7 +83,7 @@ virtual	void			_ReservedShape4();
 		friend class	TPicture;
 		friend class	BView;
 		friend class	BFont;
-		friend class	BPortLink;
+		friend class	BPrivate::ServerLink;
 
 		void			GetData(int32 *opCount, int32 *ptCount, uint32 **opList, BPoint **ptList);
 		void			SetData(int32 opCount, int32 ptCount, uint32 *opList, BPoint *ptList);

headers/os/interface/View.h

@@ -1,5 +1,5 @@
 //------------------------------------------------------------------------------
-//	Copyright (c) 2001-2002, OpenBeOS
+//	Copyright (c) 2001-2005, Haiku
 //
 //	Permission is hereby granted, free of charge, to any person obtaining a
 //	copy of this software and associated documentation files (the "Software"),
@@ -28,23 +28,13 @@
 #ifndef	_VIEW_H
 #define	_VIEW_H
 
-// Standard Includes -----------------------------------------------------------
 
-// System Includes -------------------------------------------------------------
 #include <BeBuild.h>
 #include <Font.h>
 #include <Handler.h>
 #include <InterfaceDefs.h>
 #include <Rect.h>
 
-// Project Includes ------------------------------------------------------------
-
-// Local Includes --------------------------------------------------------------
-
-// Local Defines ---------------------------------------------------------------
-
-// Globals ---------------------------------------------------------------------
-
 
 // view definitions ------------------------------------------------------------
 
@@ -675,10 +665,3 @@ inline void	BView::SetLowColor(uchar r, uchar g, uchar b, uchar a)
 //------------------------------------------------------------------------------
 
 #endif	// _VIEW_H
-
-/*
- @log
-	* added PrintToStream() method for debugging BView.
- 
- */
-

headers/os/interface/Window.h

@@ -35,7 +35,9 @@
 #include <StorageDefs.h>
 #include <View.h>
 
-class BPortLink;
+namespace BPrivate {
+	class PortLink;
+};
 
 
 // window definitions ----------------------------------------------------------
@@ -389,13 +391,9 @@ private:
 	short			fShowLevel;
 	uint32			fFlags;
 
-	port_id			send_port;
-	port_id			receive_port;
-
 	BView			*top_view;
 	BView			*fFocus;
 	BView			*fLastMouseMovedView;
-	void			*a_session;					// unusedm was _BSession_
 	BMenuBar		*fKeyMenuBar;
 	BButton			*fDefaultButton;
 	BList			accelList;
@@ -419,11 +417,11 @@ private:
 	ViewAttr		*fCurDrawViewState;			// not yet used
 	window_feel		fFeel;
 	int32			fLastViewToken;
-	BPortLink		*fLink;
+	BPrivate::PortLink	*fLink;
 	BMessageRunner	*fPulseRunner;
 	BRect			fCurrentFrame;				// not yet used
 
-	uint32			_reserved[2];	// was 8
+	uint32			_reserved[5];	// was 8
 #if !_PR3_COMPATIBLE_
 	uint32			_more_reserved[4];
 #endif