From ddd7b87d8e4c66c4b1f49ca61800d4eb6ec76938 Mon Sep 17 00:00:00 2001
From: Stefano Ceccherini <stefano.ceccherini@gmail.com>
Date: Thu, 30 Dec 2004 09:42:46 +0000
Subject: [PATCH] Small cleanup, added a TODO comment.

git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10547 a95241bf-73f2-0310-859d-f6bbb57e9c96
---
 src/kits/interface/OptionPopUp.cpp | 55 ++++++++++++++++--------------
 1 file changed, 30 insertions(+), 25 deletions(-)

diff --git a/src/kits/interface/OptionPopUp.cpp b/src/kits/interface/OptionPopUp.cpp
index 209d695359..a37940e645 100644
--- a/src/kits/interface/OptionPopUp.cpp
+++ b/src/kits/interface/OptionPopUp.cpp
@@ -124,6 +124,7 @@ BOptionPopUp::GetOptionAt(int32 index, const char **outName, int32 *outValue)
 			result = true;
 		}
 	}
+	
 	return result;
 }
 
@@ -167,29 +168,30 @@ status_t
 BOptionPopUp::AddOptionAt(const char *name, int32 value, int32 index)
 {
 	BMenu *menu = _mField->Menu();
-	if (menu != NULL) {
-		int32 numItems = menu->CountItems();
-		if (index < 0 || index > numItems)
-			return B_BAD_VALUE;
-		
-		BMessage *message = MakeValueMessage(value);
-		if (message == NULL)
-			return B_ERROR;	// TODO: Should return B_NO_MEMORY instead ?
-		
-		BMenuItem *newItem = new BMenuItem(name, message);
-		if (newItem == NULL) {
-			delete message;
-			return B_ERROR; // TODO: same as above
-		}
-		menu->AddItem(newItem, index);
-		
-		// We didnt' have any items before, so select the newly added one
-		if (numItems == 0)
-			SetValue(value);
-		return B_OK;
+	if (menu == NULL)
+		return B_ERROR;
+	
+	int32 numItems = menu->CountItems();
+	if (index < 0 || index > numItems)
+		return B_BAD_VALUE;
+	
+	BMessage *message = MakeValueMessage(value);
+	if (message == NULL)
+		return B_ERROR;	// TODO: Should return B_NO_MEMORY instead ?
+	
+	BMenuItem *newItem = new BMenuItem(name, message);
+	if (newItem == NULL) {
+		delete message;
+		return B_ERROR; // TODO: same as above
 	}
-
-	return B_ERROR;
+	
+	menu->AddItem(newItem, index);
+	
+	// We didnt' have any items before, so select the newly added one
+	if (numItems == 0)
+		SetValue(value);
+	
+	return B_OK;
 }
 
 
@@ -238,14 +240,16 @@ BOptionPopUp::SetValue(int32 value)
 {
 	BControl::SetValue(value);
 	BMenu *menu = _mField->Menu();
+	if (menu == NULL)
+		return;
 
 	int32 numItems = menu->CountItems();
 	for (int32 i = 0; i < numItems; i++) {
 		BMenuItem *item = menu->ItemAt(i);
 		if (item && item->Message()) {
-			int32 val;
-			item->Message()->FindInt32("be:value", &val);
-			if (val == value) {
+			int32 itemValue;
+			item->Message()->FindInt32("be:value", &itemValue);
+			if (itemValue == value) {
 				item->SetMarked(true);
 
 #if BEHAVE_LIKE_R5
@@ -293,6 +297,7 @@ BOptionPopUp::GetPreferredSize(float *width, float *height)
 	
 	// Iterate over all the entries in the control,
 	// and take the maximum width.
+	// TODO: Should we call BMenuField::GetPreferredSize() instead ?
 	int32 numItems = menu->CountItems();	
 	for (int32 i = 0; i < numItems; i++) {
 		BMenuItem *item = menu->ItemAt(i);