From dfb3c928f87edb68cfb3dda940e15fd8d24a003f Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Sat, 21 Sep 2019 16:00:34 +0900 Subject: [PATCH] Deskcalc: Fix 'new[]' array freed with 'delete' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fKeypad is allocated by new[] in _ParseCalcDesc(), but freed by delete. Pointed out by LGTM. Change-Id: Iac81d3cc6bfcf003ddf9146415a4400c34a1b7f2 Reviewed-on: https://review.haiku-os.org/c/haiku/+/1879 Reviewed-by: Axel Dörfler --- src/apps/deskcalc/CalcView.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps/deskcalc/CalcView.cpp b/src/apps/deskcalc/CalcView.cpp index dbbb74c5a2..f684fd686b 100644 --- a/src/apps/deskcalc/CalcView.cpp +++ b/src/apps/deskcalc/CalcView.cpp @@ -201,7 +201,7 @@ CalcView::CalcView(BMessage* archive) CalcView::~CalcView() { - delete fKeypad; + delete[] fKeypad; delete fOptions; free(fKeypadDescription); delete fEvaluateMessageRunner;