i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

With my recent changes release_sem_etc() accidentally lost the

Browse Source 
cleverness to reschedule only, if it actually unblocked another thread.
Should have been the reason for #2152 (overall slowdown).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25131 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Ingo Weinhold
2008-04-24 20:04:43 +00:00
parent 2909d9dc26
commit e225a906d2
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/system/kernel/sem.cpp
+6 -2
View File
@@ -917,6 +917,8 @@ release_sem_etc(sem_id id, int32 count, uint32 flags)
flags |= B_RELEASE_IF_WAITING_ONLY; flags |= B_RELEASE_IF_WAITING_ONLY;
} }
bool unblockedAny = false;
SpinLocker threadLocker(thread_spinlock); SpinLocker threadLocker(thread_spinlock);
while (count > 0) { while (count > 0) {
@@ -944,6 +946,7 @@ release_sem_etc(sem_id id, int32 count, uint32 flags)
sSems[slot].u.used.count += delta; sSems[slot].u.used.count += delta;
sSems[slot].u.used.net_count += delta - entry->count; sSems[slot].u.used.net_count += delta - entry->count;
count -= delta; count -= delta;
unblockedAny = true;
} else { } else {
// The thread is no longer waiting, but still queued, which // The thread is no longer waiting, but still queued, which
// means acquiration failed and we can just remove it. // means acquiration failed and we can just remove it.
@@ -959,8 +962,9 @@ release_sem_etc(sem_id id, int32 count, uint32 flags)
if (sSems[slot].u.used.count > 0) if (sSems[slot].u.used.count > 0)
notify_sem_select_events(&sSems[slot], B_EVENT_ACQUIRE_SEMAPHORE); notify_sem_select_events(&sSems[slot], B_EVENT_ACQUIRE_SEMAPHORE);
// reschedule, if we've not explicitly been told not to // If we've unblocked another thread reschedule, if we've not explicitly
if ((flags & B_DO_NOT_RESCHEDULE) == 0) { // been told not to.
if (unblockedAny && (flags & B_DO_NOT_RESCHEDULE) == 0) {
semLocker.Unlock(); semLocker.Unlock();
threadLocker.Lock(); threadLocker.Lock();
scheduler_reschedule(); scheduler_reschedule();