From e2685c735facd60521d240747d52c41a651e540d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samuel=20Rodr=C3=ADguez=20P=C3=A9rez?= Date: Fri, 14 Nov 2025 15:17:19 +0000 Subject: [PATCH] input mouse mm: Reset tap statuses on any button presss or on more than two fingers This fixes incorrect fast double taps issuing click and other misbehaviours when on two-finger or more-than-two-finger events happened at the same time. Apart from that, it fixed incorrect tap statuses checking for all change of buttons instead of only from kLeftButton. The latest is commented to easily find each tap related button status changes and checks retated to tap handling. Clean up - Removal of kLeftButton check that was in place from previous as a condition for tap related statuses. Now checking for whatever button. Change-Id: Ied6a829022cd4e8601a7432fdfc71b08446a642d Reviewed-on: https://review.haiku-os.org/c/haiku/+/9916 Tested-by: Commit checker robot Reviewed-by: Adrien Destugues --- src/add-ons/input_server/devices/mouse/movement_maker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/add-ons/input_server/devices/mouse/movement_maker.cpp b/src/add-ons/input_server/devices/mouse/movement_maker.cpp index 9a68213501..8db3eb6535 100644 --- a/src/add-ons/input_server/devices/mouse/movement_maker.cpp +++ b/src/add-ons/input_server/devices/mouse/movement_maker.cpp @@ -362,7 +362,7 @@ TouchpadMovement::EventToMovement(const touchpad_movement* event, mouse_movement } } - if (event->buttons & kLeftButton) { + if (event->buttons || two_or_more_fingers(event)) { fTapClicks = 0; fTapdragStarted = false; fTapStarted = false;