From e315daa9c1ddc75e252aa8f15c88857f14ff5ca8 Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Fri, 13 Sep 2019 22:10:23 -0400 Subject: [PATCH] kernel/thread: Clarify permissions checking logic. No functional change intended; but if I missed a case, it will now be caught by the "return false" instead of the "return true", which is a better default. --- src/system/kernel/thread.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/system/kernel/thread.cpp b/src/system/kernel/thread.cpp index a893434374..4ea3f605c7 100644 --- a/src/system/kernel/thread.cpp +++ b/src/system/kernel/thread.cpp @@ -3008,12 +3008,12 @@ thread_check_permissions(const Thread* currentThread, const Thread* thread, if (thread->team->id == team_get_kernel_team_id()) return false; - if (thread->team != currentThread->team - && currentThread->team->effective_uid != 0 - && thread->team->real_uid != currentThread->team->real_uid) - return false; + if (thread->team == currentThread->team + || currentThread->team->effective_uid == 0 + || thread->team->real_uid == currentThread->team->real_uid) + return true; - return true; + return false; }