i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Getting the screen mode should be protected, at least by a read lock.

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32420 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stefano Ceccherini
2009-08-15 17:22:19 +00:00
parent e8cbd8db5d
commit e4ea54bdb7
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/servers/app/ServerApp.cpp
+13 -10
View File
@@ -2285,15 +2285,18 @@ ServerApp::_DispatchMessage(int32 code, BPrivate::LinkReceiver& link)
uint32 workspace; uint32 workspace;
link.Read<uint32>(&workspace); link.Read<uint32>(&workspace);
// TODO: the display_mode can be different between
// the various screens.
// We have the screen_id and the workspace number, with these we
// need to find the corresponding "driver", and call getmode on it
display_mode mode; display_mode mode;
fDesktop->ScreenAt(0)->GetMode(&mode); if (fDesktop->LockSingleWindow()) {
// actually this isn't still enough as different workspaces can // TODO: the display_mode can be different between
// have different display_modes // the various screens.
// We have the screen_id and the workspace number,
// with these we need to find the corresponding
// "driver", and call getmode on it
fDesktop->ScreenAt(0)->GetMode(&mode);
// actually this isn't still enough as different
// workspaces can have different display_modes
fDesktop->UnlockSingleWindow();
}
fLink.StartMessage(B_OK); fLink.StartMessage(B_OK);
fLink.Attach<display_mode>(mode); fLink.Attach<display_mode>(mode);
fLink.Flush(); fLink.Flush();
@@ -2995,9 +2998,9 @@ ServerApp::CreatePicture(const ServerPicture* original)
{ {
ServerPicture* picture; ServerPicture* picture;
if (original != NULL) if (original != NULL)
picture = new(std::nothrow) ServerPicture(*original); picture = new (std::nothrow) ServerPicture(*original);
else else
picture = new(std::nothrow) ServerPicture(); picture = new (std::nothrow) ServerPicture();
if (picture != NULL) if (picture != NULL)
fPictureList.AddItem(picture); fPictureList.AddItem(picture);