From e74e02ac054deb5815bc60b7486685b0c0534acb Mon Sep 17 00:00:00 2001 From: Barrett17 Date: Sun, 25 Feb 2018 23:40:35 +0100 Subject: [PATCH] MediaClient: Update docs and add TODOs --- headers/private/media/experimental/MediaClient.h | 4 ++-- headers/private/media/experimental/MediaConnection.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/headers/private/media/experimental/MediaClient.h b/headers/private/media/experimental/MediaClient.h index 019bbdd8c7..7a2cd66c49 100755 --- a/headers/private/media/experimental/MediaClient.h +++ b/headers/private/media/experimental/MediaClient.h @@ -117,6 +117,7 @@ public: status_t Roll(bigtime_t start, bigtime_t stop, bigtime_t seek); + // TODO: We really want to expose Preroll and SyncTo? // Preroll the client to buffer startup latency status_t Preroll(); @@ -124,8 +125,7 @@ public: status_t SyncTo(bigtime_t performanceTime, bigtime_t timeout = -1); - // Return the current performance time handled by the object when - // run_mode != B_OFFLINE. Otherwise returns the current offline time. + // Return the current performance time handled by the client. bigtime_t CurrentTime() const; // This is supplied to support using this class in a BMediaAddOn. diff --git a/headers/private/media/experimental/MediaConnection.h b/headers/private/media/experimental/MediaConnection.h index 002225df82..bc46acd51f 100644 --- a/headers/private/media/experimental/MediaConnection.h +++ b/headers/private/media/experimental/MediaConnection.h @@ -153,6 +153,8 @@ protected: virtual status_t PrepareToConnect(media_format* format); virtual status_t FormatProposal(media_format* format); + + // TODO: Do we really want this? virtual status_t FormatChangeRequested(media_format* format); // When a connection is not binded with another, and you really don't want