From e7babe14ba87cfb4bd0794d5081c725b54d1ab04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= Date: Sun, 24 Aug 2014 18:19:10 +0200 Subject: [PATCH] MessageBuilder: Whoops, stringDeleter must be detached when adding succeeded. --- src/kits/shared/MessageBuilder.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/kits/shared/MessageBuilder.cpp b/src/kits/shared/MessageBuilder.cpp index 84013dffb4..2cd28e1427 100644 --- a/src/kits/shared/MessageBuilder.cpp +++ b/src/kits/shared/MessageBuilder.cpp @@ -43,11 +43,11 @@ BMessageBuilder::PushObject(const char* name) if (!fNameStack.AddItem(nameString)) return B_NO_MEMORY; + stringDeleter.Detach(); + if (!fStack.AddItem(fCurrentMessage)) return B_NO_MEMORY; - messageDeleter.Detach(); - stringDeleter.Detach(); fCurrentMessage = newMessage; return B_OK;