i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added some comments, made bfs_create() a bit nicer (no functional change, though).

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1929 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler
2002-11-14 00:22:16 +00:00
parent 601f33e246
commit e94373bfa0
1 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/file_systems/bfs/kernel_interface.cpp
+18 -10
View File
@@ -765,9 +765,10 @@ bfs_write_stat(void *_ns, void *_node, struct stat *stat, long mask)
int int
bfs_create(void *_ns, void *_directory, const char *name, int omode, int mode, vnode_id *vnid, void **_cookie) bfs_create(void *_ns, void *_directory, const char *name, int omode, int mode,
vnode_id *vnodeID, void **_cookie)
{ {
FUNCTION_START(("name = \"%s\", perms = %ld, omode = %ld\n",name,mode,omode)); FUNCTION_START(("name = \"%s\", perms = %ld, omode = %ld\n", name, mode, omode));
if (_ns == NULL || _directory == NULL || _cookie == NULL if (_ns == NULL || _directory == NULL || _cookie == NULL
|| name == NULL || *name == '\0') || name == NULL || *name == '\0')
@@ -783,6 +784,8 @@ bfs_create(void *_ns, void *_directory, const char *name, int omode, int mode, v
if (status < B_OK) if (status < B_OK)
RETURN_ERROR(status); RETURN_ERROR(status);
// We are creating the cookie at this point, so that we don't have
// to remove the inode if we don't have enough free memory later...
file_cookie *cookie = (file_cookie *)malloc(sizeof(file_cookie)); file_cookie *cookie = (file_cookie *)malloc(sizeof(file_cookie));
if (cookie == NULL) if (cookie == NULL)
RETURN_ERROR(B_NO_MEMORY); RETURN_ERROR(B_NO_MEMORY);
@@ -792,19 +795,21 @@ bfs_create(void *_ns, void *_directory, const char *name, int omode, int mode, v
cookie->last_size = 0; cookie->last_size = 0;
cookie->last_notification = system_time(); cookie->last_notification = system_time();
Transaction transaction(volume,directory->BlockNumber()); Transaction transaction(volume, directory->BlockNumber());
status = Inode::Create(&transaction,directory,name,S_FILE | (mode & S_IUMSK),omode,0,vnid); status = Inode::Create(&transaction, directory, name, S_FILE | (mode & S_IUMSK),
if (status == B_OK) { omode, 0, vnodeID);
if (status >= B_OK) {
transaction.Done(); transaction.Done();
notify_listener(B_ENTRY_CREATED,volume->ID(),directory->ID(),0,*vnid,name); // register the cookie
}
if (status < B_OK)
free(cookie);
else
*_cookie = cookie; *_cookie = cookie;
notify_listener(B_ENTRY_CREATED, volume->ID(), directory->ID(), 0, *vnodeID, name);
} else
free(cookie);
return status; return status;
} }
@@ -1254,6 +1259,9 @@ bfs_close(void *_ns, void *_node, void *_cookie)
if (inode->Flags() & INODE_NO_CACHE) { if (inode->Flags() & INODE_NO_CACHE) {
volume->Pool().ReleaseBuffers(); volume->Pool().ReleaseBuffers();
inode->Node()->flags &= ~INODE_NO_CACHE; inode->Node()->flags &= ~INODE_NO_CACHE;
// We don't need to save the inode, because INODE_NO_CACHE is a
// non-permanent flag which will be removed when the inode is loaded
// into memory.
} }
return B_OK; return B_OK;