From e975b31db334fa84e61d3c59228eb72660759f0d Mon Sep 17 00:00:00 2001 From: Pawel Dziepak Date: Tue, 19 Mar 2013 00:36:49 +0100 Subject: [PATCH] nfs4: Ensure that a string is NULL terminated after strncpy() This fixes CID 990971. --- src/add-ons/kernel/file_systems/nfs4/RootInode.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/add-ons/kernel/file_systems/nfs4/RootInode.cpp b/src/add-ons/kernel/file_systems/nfs4/RootInode.cpp index a215d6bb7b..5278cf8f51 100644 --- a/src/add-ons/kernel/file_systems/nfs4/RootInode.cpp +++ b/src/add-ons/kernel/file_systems/nfs4/RootInode.cpp @@ -135,7 +135,8 @@ RootInode::_UpdateInfo(bool force) || fFileSystem->GetConfiguration().fEmulateNamedAttrs) fInfoCache.flags |= B_FS_HAS_MIME | B_FS_HAS_ATTR; - strncpy(fInfoCache.volume_name, fName, B_FILE_NAME_LENGTH); + strncpy(fInfoCache.volume_name, fName, sizeof(fInfoCache.volume_name)); + fInfoCache.volume_name[sizeof(fInfoCache.volume_name) - 1] = '\0'; fInfoCacheExpire = time(NULL) + MetadataCache::kExpirationTime;