From e9815ed8b6cf3f275c2626f018c609de16031e71 Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Sat, 4 Jul 2020 19:39:43 -0400 Subject: [PATCH] BScrollBar: Move SCROLL_BAR_{...}_KNOB_SIZE constants into the source. They were not used anywhere else in the tree anyway. Resolves a TODO. --- headers/os/interface/ScrollBar.h | 4 ---- src/kits/interface/ScrollBar.cpp | 3 +++ 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/headers/os/interface/ScrollBar.h b/headers/os/interface/ScrollBar.h index 557d11c118..fb3d37e2be 100644 --- a/headers/os/interface/ScrollBar.h +++ b/headers/os/interface/ScrollBar.h @@ -12,10 +12,6 @@ #define B_V_SCROLL_BAR_WIDTH 14.0f #define B_H_SCROLL_BAR_HEIGHT 14.0f -// TODO: shouldn't these be moved into the implementation? -#define SCROLL_BAR_MAXIMUM_KNOB_SIZE 50 -#define SCROLL_BAR_MINIMUM_KNOB_SIZE 9 - #define DISABLES_ON_WINDOW_DEACTIVATION 1 diff --git a/src/kits/interface/ScrollBar.cpp b/src/kits/interface/ScrollBar.cpp index 2ad9d659d8..ab5077d640 100644 --- a/src/kits/interface/ScrollBar.cpp +++ b/src/kits/interface/ScrollBar.cpp @@ -45,6 +45,9 @@ typedef enum { } arrow_direction; +#define SCROLL_BAR_MAXIMUM_KNOB_SIZE 50 +#define SCROLL_BAR_MINIMUM_KNOB_SIZE 9 + #define SBC_SCROLLBYVALUE 0 #define SBC_SETDOUBLE 1 #define SBC_SETPROPORTIONAL 2