i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correction to previous leak fix.

Browse Source 
- The actual reason the hidden node wasn't being released as expected
  was that ContainerListener::ModelNodeHidden() added a reference on
  behalf of its indirect target, while the latter never actually
  took ownership of said reference.
This commit is contained in:
Rene Gollent
2012-11-30 21:15:57 -05:00
parent f4621a90de
commit ea788ed9cb
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp
+4 -2
View File
@@ -1036,7 +1036,7 @@ VariablesView::VariableTableModel::ValueNodeChildrenDeleted(ValueNode* node)
BReference<ModelNode> hiddenChild; BReference<ModelNode> hiddenChild;
if (modelNode->CountChildren() == 1 if (modelNode->CountChildren() == 1
&& modelNode->ChildAt(0)->IsHidden()) { && modelNode->ChildAt(0)->IsHidden()) {
hiddenChild.SetTo(modelNode->ChildAt(0), true); hiddenChild.SetTo(modelNode->ChildAt(0));
modelNode->RemoveChild(hiddenChild); modelNode->RemoveChild(hiddenChild);
modelNode = hiddenChild; modelNode = hiddenChild;
fNodeTable.Remove(hiddenChild); fNodeTable.Remove(hiddenChild);
@@ -1788,8 +1788,10 @@ VariablesView::MessageReceived(BMessage* message)
case MSG_MODEL_NODE_HIDDEN: case MSG_MODEL_NODE_HIDDEN:
{ {
ModelNode* node; ModelNode* node;
if (message->FindPointer("node", (void**)&node) == B_OK) if (message->FindPointer("node", (void**)&node) == B_OK) {
BReference<ModelNode> modelNodeReference(node, true);
_RequestNodeValue(node); _RequestNodeValue(node);
}
break; break;
} }