From eadeecc2ff3e3c63612a73d24834b1553ed54135 Mon Sep 17 00:00:00 2001 From: Ingo Weinhold Date: Mon, 3 Sep 2007 20:35:27 +0000 Subject: [PATCH] Updated TODO. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22159 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/system/kernel/signal.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/system/kernel/signal.cpp b/src/system/kernel/signal.cpp index 8ac3bba25f..a7284108c9 100644 --- a/src/system/kernel/signal.cpp +++ b/src/system/kernel/signal.cpp @@ -113,10 +113,15 @@ handle_signals(struct thread *thread) debugSignal = !(~atomic_get(&thread->team->debug_info.flags) & (B_TEAM_DEBUG_SIGNALS | B_TEAM_DEBUG_DEBUGGER_INSTALLED)); - // ToDo: since sigaction_etc() could clobber the fields at any time, + // TODO: since sigaction_etc() could clobber the fields at any time, // we should actually copy the relevant fields atomically before // accessing them (only the debugger is calling sigaction_etc() // right now). + // Update: sigaction_etc() is only used by the userland debugger + // support. We can just as well restrict getting/setting signal + // handlers to work only when the respective thread is stopped. + // Then sigaction() could be used instead and we could get rid of + // sigaction_etc(). handler = &thread->sig_action[i]; TRACE(("Thread 0x%lx received signal %s\n", thread->id, sigstr[signal]));