i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add-ons/kernel/busses/i2c: Fix Memory leak

Browse Source 
Fix init_device() was exited without releasing the 'bus' pointer.
Pointed out by cppcheck.

Change-Id: I0ec1a78caa83d7d34a3d88fee64716dcbbc82dd2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2951
Reviewed-by: waddlesplash <[email protected]>
This commit is contained in:
Murai Takashi
2020-06-25 14:09:30 +00:00
committed by waddlesplash
parent 9bc51ee07c
commit ece405c749
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/busses/i2c/pch_i2c_acpi.cpp
+2
View File
@@ -131,10 +131,12 @@ init_device(device_node* node, void** device_cookie)
pch_i2c_scan_parse_callback, &crs); pch_i2c_scan_parse_callback, &crs);
if (status != B_OK) { if (status != B_OK) {
ERROR("Error while getting I2C devices\n"); ERROR("Error while getting I2C devices\n");
free(bus);
return status; return status;
} }
if (crs.addr_bas == 0 || crs.addr_len == 0) { if (crs.addr_bas == 0 || crs.addr_len == 0) {
TRACE("skipping non configured I2C devices\n"); TRACE("skipping non configured I2C devices\n");
free(bus);
return B_BAD_VALUE; return B_BAD_VALUE;
} }