i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FAT: Fix potential dereference of NULL pointer

Browse Source 
* Can occur if bread() returns an error code in readep().
* Fixes #19105.

Change-Id: I975c7d729c59b175c4a6249bbb4660e1294a0ef1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8363
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
This commit is contained in:
Jim906
2024-09-24 14:59:36 +00:00
committed by waddlesplash
parent 6b4ccaa5be
commit ed37f3a29d
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/file_systems/fat/bsd/kern/vfs_bio.c
+6 -3
View File
@@ -204,13 +204,16 @@ bawrite(struct buf* bp)
void void
brelse(struct buf* bp) brelse(struct buf* bp)
{ {
if (bp->b_vreg != NULL) {
put_buf(bp);
return;
}
struct mount* bsdVolume = bp->b_vp->v_rdev->si_mountpt; struct mount* bsdVolume = bp->b_vp->v_rdev->si_mountpt;
void* blockCache = bsdVolume->mnt_cache; void* blockCache = bsdVolume->mnt_cache;
bool readOnly = MOUNTED_READ_ONLY(VFSTOMSDOSFS(bsdVolume)); bool readOnly = MOUNTED_READ_ONLY(VFSTOMSDOSFS(bsdVolume));
if (bp->b_vreg != NULL) { if (bp->b_owned == false) {
put_buf(bp);
} else if (bp->b_owned == false) {
if (readOnly == true) if (readOnly == true)
block_cache_set_dirty(blockCache, bp->b_blkno, false, -1); block_cache_set_dirty(blockCache, bp->b_blkno, false, -1);
block_cache_put(blockCache, bp->b_blkno); block_cache_put(blockCache, bp->b_blkno);