i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app_server: fix direct assignment in alpha pixel composite

Browse Source 
* 'alpha' is 16 bit (alpha * cover) in blend_hline_alpha_pc(), so
  compare with 255 * 255
This commit is contained in:
Julian Harnath
2015-08-23 01:00:23 +02:00
parent 01c7304204
commit ed7b139e08
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/servers/app/drawing/Painter/drawing_modes/DrawingModeAlphaPC.h
+6 -6
View File
@@ -43,7 +43,7 @@ blend_pixel_alpha_pc(int x, int y, const color_type& c, uint8 cover,
// blend_hline_alpha_pc // blend_hline_alpha_pc
void void
blend_hline_alpha_pc(int x, int y, unsigned len, blend_hline_alpha_pc(int x, int y, unsigned len,
const color_type& c, uint8 cover, const color_type& c, uint8 cover,
agg_buffer* buffer, const PatternHandler* pattern) agg_buffer* buffer, const PatternHandler* pattern)
{ {
@@ -52,7 +52,7 @@ blend_hline_alpha_pc(int x, int y, unsigned len,
rgb_color color = pattern->ColorAt(x, y); rgb_color color = pattern->ColorAt(x, y);
uint16 alpha = color.alpha * cover; uint16 alpha = color.alpha * cover;
if (alpha) { if (alpha) {
if (alpha == 255) { if (alpha == 255 * 255) {
ASSIGN_ALPHA_PC(p, color.red, color.green, color.blue); ASSIGN_ALPHA_PC(p, color.red, color.green, color.blue);
} else { } else {
BLEND_ALPHA_PC(p, color.red, color.green, color.blue, alpha); BLEND_ALPHA_PC(p, color.red, color.green, color.blue, alpha);
@@ -65,7 +65,7 @@ blend_hline_alpha_pc(int x, int y, unsigned len,
// blend_solid_hspan_alpha_pc // blend_solid_hspan_alpha_pc
void void
blend_solid_hspan_alpha_pc(int x, int y, unsigned len, blend_solid_hspan_alpha_pc(int x, int y, unsigned len,
const color_type& c, const uint8* covers, const color_type& c, const uint8* covers,
agg_buffer* buffer, const PatternHandler* pattern) agg_buffer* buffer, const PatternHandler* pattern)
{ {
@@ -88,7 +88,7 @@ blend_solid_hspan_alpha_pc(int x, int y, unsigned len,
// blend_solid_vspan_alpha_pc // blend_solid_vspan_alpha_pc
void void
blend_solid_vspan_alpha_pc(int x, int y, unsigned len, blend_solid_vspan_alpha_pc(int x, int y, unsigned len,
const color_type& c, const uint8* covers, const color_type& c, const uint8* covers,
agg_buffer* buffer, const PatternHandler* pattern) agg_buffer* buffer, const PatternHandler* pattern)
{ {
@@ -112,8 +112,8 @@ blend_solid_vspan_alpha_pc(int x, int y, unsigned len,
// blend_color_hspan_alpha_pc // blend_color_hspan_alpha_pc
void void
blend_color_hspan_alpha_pc(int x, int y, unsigned len, blend_color_hspan_alpha_pc(int x, int y, unsigned len,
const color_type* colors, const color_type* colors,
const uint8* covers, uint8 cover, const uint8* covers, uint8 cover,
agg_buffer* buffer, const PatternHandler* pattern) agg_buffer* buffer, const PatternHandler* pattern)
{ {