From ee96bcfe512d8ed61126fd58acac612082762187 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Sat, 6 Aug 2022 05:57:24 +0900 Subject: [PATCH] network/dns_resolver: fix memory leak 'reply' is allocated in Serialize() at line 120, but is not freed. Pointed out by Clang Static Analyzer. Change-Id: I9f7e0c5c2dcb976f11230ad8a5ba38d653b23d6d Reviewed-on: https://review.haiku-os.org/c/haiku/+/5530 Reviewed-by: Fredrik Holmqvist Tested-by: Commit checker robot --- src/add-ons/kernel/network/dns_resolver/server/main.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/add-ons/kernel/network/dns_resolver/server/main.cpp b/src/add-ons/kernel/network/dns_resolver/server/main.cpp index 4052aed5ee..813a2a7c54 100644 --- a/src/add-ons/kernel/network/dns_resolver/server/main.cpp +++ b/src/add-ons/kernel/network/dns_resolver/server/main.cpp @@ -121,7 +121,9 @@ GetAddrInfo(const char* buffer) freeaddrinfo(ai); if (result != B_OK) return write_port(gReplyPort, MsgError, &result, sizeof(result)); - return write_port(gReplyPort, MsgReply, reply, totalSize); + result = write_port(gReplyPort, MsgReply, reply, totalSize); + free(reply); + return result; }