From ef7fb431edae5dce89a52bdc822a6bdbc104cf80 Mon Sep 17 00:00:00 2001 From: Rene Gollent Date: Wed, 23 Jul 2008 21:39:48 +0000 Subject: [PATCH] Remove extraneous put_vnode(). This would result in decrementing the vnode ref count even if an unmount operation failed, which in turn would cause other fun problems. This fixes tickets 1982 and 2538. However, there seems to be another problem remaining with unmounting: the placeholder dir in the rootfs is not removed when the volume is unmounted, or it's not reused correctly. As a consequence, on subsequent remounts of the same volume via Tracker or mountvolume, a new dir is created each time, leaving empty placeholders. (i.e. remounting the volume HaikuData results in the creation of /HaikuData1, 2, 3, 4, etc.). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26586 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/system/kernel/fs/vfs.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/system/kernel/fs/vfs.cpp b/src/system/kernel/fs/vfs.cpp index 56bf6ab2fe..78e56c0050 100644 --- a/src/system/kernel/fs/vfs.cpp +++ b/src/system/kernel/fs/vfs.cpp @@ -6579,7 +6579,6 @@ fs_unmount(char *path, dev_t mountID, uint32 flags, bool kernel) if ((flags & B_FORCE_UNMOUNT) == 0) { mutex_unlock(&sVnodeMutex); - put_vnode(mount->root_vnode); return B_BUSY; }