From f0a1a07c73fa7a5275a46184467ceb429634cdba Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Tue, 27 Nov 2018 20:41:15 +0900 Subject: [PATCH] RegionSupport: Fix PVS 338-346 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix 'true / false' value is implicitly cast to the integer type. Change-Id: I2f72fcd34d2d97d20e2a98ed5efe25919a485c9d Reviewed-on: https://review.haiku-os.org/739 Reviewed-by: Jérôme Duval --- headers/private/interface/RegionSupport.h | 2 +- src/kits/interface/RegionSupport.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/headers/private/interface/RegionSupport.h b/headers/private/interface/RegionSupport.h index dee1351bec..6cb5984c27 100644 --- a/headers/private/interface/RegionSupport.h +++ b/headers/private/interface/RegionSupport.h @@ -65,7 +65,7 @@ class BRegion::Support { static int XXorRegion(const BRegion* sra, const BRegion* srb, BRegion* dr); - static int XPointInRegion(const BRegion* region, + static bool XPointInRegion(const BRegion* region, int x, int y); enum { diff --git a/src/kits/interface/RegionSupport.cpp b/src/kits/interface/RegionSupport.cpp index 95b022b490..be2eda6e46 100644 --- a/src/kits/interface/RegionSupport.cpp +++ b/src/kits/interface/RegionSupport.cpp @@ -1542,7 +1542,7 @@ BRegion::Support::XXorRegion(const BRegion* sra, const BRegion* srb, } -int +bool BRegion::Support::XPointInRegion( const BRegion* pRegion, int x, int y) @@ -1570,7 +1570,7 @@ BRegion::Support::XRectInRegion( register clipping_rect* pbox; register clipping_rect* pboxEnd; register const clipping_rect* prect = ▭ - int partIn, partOut; + bool partIn, partOut; int rx = prect->left; int ry = prect->top;