From f28e05bce54338fe462faef9e4e0d3a0efebb425 Mon Sep 17 00:00:00 2001
From: Fredrik Holmqvist <fredrik.holmqvist@gmail.com>
Date: Tue, 19 Jul 2022 11:58:17 +0200
Subject: [PATCH] Web+: Use reference for urlcontext in app and window

It needs to be deleted after everything is done.
This seems to fix the crashes I could reproduce on exit in my VM.
So might fix #17583.
(WebView also has fContext, but I assume they are part of a window)

Change-Id: I0125f76b0b2331ac3b6a81d6c20087ebdedbf2f2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5486
Reviewed-by: Fredrik Holmqvist <fredrik.holmqvist@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
---
 src/apps/webpositive/BrowserApp.cpp  | 1 -
 src/apps/webpositive/BrowserApp.h    | 2 +-
 src/apps/webpositive/BrowserWindow.h | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/apps/webpositive/BrowserApp.cpp b/src/apps/webpositive/BrowserApp.cpp
index 4827012b54..c08fea248e 100644
--- a/src/apps/webpositive/BrowserApp.cpp
+++ b/src/apps/webpositive/BrowserApp.cpp
@@ -125,7 +125,6 @@ BrowserApp::~BrowserApp()
 	delete fSettings;
 	delete fCookies;
 	delete fSession;
-	delete fContext;
 }
 
 
diff --git a/src/apps/webpositive/BrowserApp.h b/src/apps/webpositive/BrowserApp.h
index 56216af231..845c9085a1 100644
--- a/src/apps/webpositive/BrowserApp.h
+++ b/src/apps/webpositive/BrowserApp.h
@@ -80,7 +80,7 @@ private:
 			SettingsMessage*	fSettings;
 			SettingsMessage*	fCookies;
 			SettingsMessage*	fSession;
-			BPrivate::Network::BUrlContext*	fContext;
+			BReference<BPrivate::Network::BUrlContext>	fContext;
 
 			DownloadWindow*		fDownloadWindow;
 			SettingsWindow*		fSettingsWindow;
diff --git a/src/apps/webpositive/BrowserWindow.h b/src/apps/webpositive/BrowserWindow.h
index bf5ea75953..1b292b550d 100644
--- a/src/apps/webpositive/BrowserWindow.h
+++ b/src/apps/webpositive/BrowserWindow.h
@@ -266,7 +266,7 @@ private:
 			bigtime_t			fLastMouseMovedTime;
 			BPoint				fLastMousePos;
 
-			BPrivate::Network::BUrlContext*	fContext;
+			BReference<BPrivate::Network::BUrlContext>	fContext;
 
 			// cached settings
 			SettingsMessage*	fAppSettings;