From f465c7fa619a31eabf63b5e8d72edcdf78982c8e Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Fri, 1 Feb 2019 05:38:10 +0900 Subject: [PATCH] kits/midi2: Fix PVS 820 Fix memory leak when realloc() fails. Change-Id: Ic787ca714e4a106cc22e6186078a8e72d0a0553d Reviewed-on: https://review.haiku-os.org/c/1006 Reviewed-by: waddlesplash --- src/kits/midi2/MidiLocalConsumer.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/kits/midi2/MidiLocalConsumer.cpp b/src/kits/midi2/MidiLocalConsumer.cpp index 1ab05a5c1c..d661614982 100644 --- a/src/kits/midi2/MidiLocalConsumer.cpp +++ b/src/kits/midi2/MidiLocalConsumer.cpp @@ -345,7 +345,10 @@ BMidiLocalConsumer::EventThread() break; // error reading port if (msg_size > buf_size) { - buffer = (uint8*) realloc(buffer, msg_size); + uint8* tmp_buffer = (uint8*) realloc(buffer, msg_size); + if (tmp_buffer == NULL) + break; // error in realloc() + buffer = tmp_buffer; buf_size = msg_size; }