From f87b5b98034392c992508a266c95e87345ed6d10 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= <superstippi@gmx.de>
Date: Sat, 29 Apr 2006 16:36:31 +0000
Subject: [PATCH] long overdue fix for BScrollBar. fValue is now set in
 SetValue() instead of ValueChanged(). This fixes BScrollBar implementations
 which don't call the inherited version of ValueChanged(). All kinds of weird
 behaviour seems to be fixed by this: StyledEdit window resizing, scrolling in
 Pe, WonderBrush, eXposer and maybe more.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17263 a95241bf-73f2-0310-859d-f6bbb57e9c96
---
 src/kits/interface/ScrollBar.cpp | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/kits/interface/ScrollBar.cpp b/src/kits/interface/ScrollBar.cpp
index 4aa444882d..547bb439ae 100644
--- a/src/kits/interface/ScrollBar.cpp
+++ b/src/kits/interface/ScrollBar.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2001-2005, Haiku, Inc.
+ * Copyright (c) 2001-2006, Haiku, Inc.
  * Distributed under the terms of the MIT license.
  *
  * Authors:
@@ -291,6 +291,7 @@ an actual BView within the scroll bar's window.
 void
 BScrollBar::SetValue(float value)
 {
+//printf("BScrollBar::SetValue(%.1f)\n", value);
 	if (value == fValue)
 		return;
 
@@ -299,6 +300,12 @@ BScrollBar::SetValue(float value)
 	if (value < fMin)
 		value = fMin;
 
+	fValue = value;
+
+	_UpdateThumbFrame();
+	_UpdateArrowButtons();
+
+//printf(" -> calling ValueChanged()\n");
 	ValueChanged(value);
 }
 
@@ -313,6 +320,7 @@ BScrollBar::Value() const
 void
 BScrollBar::ValueChanged(float newValue)
 {
+printf("BScrollBar::ValueChanged(%.1f)\n", newValue);
 	if (fTarget) {
 		// cache target bounds
 		BRect targetBounds = fTarget->Bounds();
@@ -326,10 +334,7 @@ BScrollBar::ValueChanged(float newValue)
 		}
 	}
 
-	fValue = newValue;
-
-	_UpdateThumbFrame();
-	_UpdateArrowButtons();
+	SetValue(newValue);
 }
 
 // SetProportion