i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cortex: Bounds checks in AudioFilterNode::processBuffer.

Browse Source 
Processing more than framesRemaining leads to buffer overruns.
This commit is contained in:
Augustin Cavalier
2021-09-07 16:18:22 -04:00
parent dc912367ae
commit f91a86c46f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/apps/cortex/addons/common/AudioFilterNode.cpp
+4 -4
View File
@@ -1498,6 +1498,9 @@ void AudioFilterNode::processBuffer(
ASSERT(toProcess > 0); ASSERT(toProcess > 0);
if (toProcess > framesRemaining)
toProcess = framesRemaining;
uint32 processed = m_op->process( uint32 processed = m_op->process(
input, output, sourceOffset, destinationOffset, (uint32)toProcess, targetTime); input, output, sourceOffset, destinationOffset, (uint32)toProcess, targetTime);
if(processed < toProcess) { if(processed < toProcess) {
@@ -1506,10 +1509,7 @@ void AudioFilterNode::processBuffer(
"*** AudioFilterNode::processBuffer(): insufficient frames filled\n")); "*** AudioFilterNode::processBuffer(): insufficient frames filled\n"));
} }
if(toProcess > framesRemaining) framesRemaining -= toProcess;
framesRemaining = 0;
else
framesRemaining -= toProcess;
// advance target time // advance target time
targetTime = nextEventTime; // +++++ might this drift from the real frame offset? targetTime = nextEventTime; // +++++ might this drift from the real frame offset?