From fb4fd84f4dcd4ee910143eb46c600fe2b842d142 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Thu, 15 Oct 2020 18:34:54 +0900 Subject: [PATCH] packageinstaller: Fix -Wformat-security MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I9792b89ed0b59d509f20c43170f806a6168cbf81 Reviewed-on: https://review.haiku-os.org/c/haiku/+/3347 Reviewed-by: Jérôme Duval --- src/apps/packageinstaller/PackageView.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/apps/packageinstaller/PackageView.cpp b/src/apps/packageinstaller/PackageView.cpp index 9cdf1cc0c4..9614106017 100644 --- a/src/apps/packageinstaller/PackageView.cpp +++ b/src/apps/packageinstaller/PackageView.cpp @@ -223,8 +223,8 @@ PackageView::MessageReceived(BMessage* message) "distributor."), B_TRANSLATE("OK"), NULL, NULL, B_WIDTH_AS_USUAL, B_WARNING_ALERT); - fprintf(stderr, - B_TRANSLATE("Error while installing the package\n")); + fputs(B_TRANSLATE("Error while installing the package\n"), + stderr); notify->SetFlags(notify->Flags() | B_CLOSE_ON_ESCAPE); notify->Go(); fStatusWindow->Hide(); @@ -390,7 +390,7 @@ PackageView::ItemExists(PackageItem& item, BPath& path, int32& policy) // TODO: Maybe add 'No, but ask again' type of choice as well? alertString = B_TRANSLATE("Do you want to remember this " "decision for the rest of this installation?\n"); - + BString actionString; if (choice == P_EXISTS_OVERWRITE) { alertString << B_TRANSLATE( @@ -645,7 +645,7 @@ PackageView::_InstallTypeChanged(int32 index) char volumeName[B_FILE_NAME_LENGTH]; volume.GetName(volumeName); - + BMenuItem* item = _AddDestinationMenuItem(volumeName, volume.FreeBytes(), path.Path());