From fd9a9adcc0c5c6e07274a79a37c9a9b08662aafb Mon Sep 17 00:00:00 2001
From: Rudolf Cornelissen <rudolf.cornelissen@gmail.com>
Date: Thu, 1 Jul 2004 14:20:18 +0000
Subject: [PATCH] final ROMdump update: fixes shutting off of most cards (pre
 NV18)

git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8252 a95241bf-73f2-0310-859d-f6bbb57e9c96
---
 src/add-ons/kernel/drivers/graphics/nvidia/UPDATE.html | 5 +++--
 src/add-ons/kernel/drivers/graphics/nvidia/driver.c    | 7 ++++++-
 2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/add-ons/kernel/drivers/graphics/nvidia/UPDATE.html b/src/add-ons/kernel/drivers/graphics/nvidia/UPDATE.html
index c1c928fb93..f2a141cd9d 100644
--- a/src/add-ons/kernel/drivers/graphics/nvidia/UPDATE.html
+++ b/src/add-ons/kernel/drivers/graphics/nvidia/UPDATE.html
@@ -4,13 +4,14 @@
 </head>
 <body>
 <p><h2>Changes done for each driverversion:</h2></p>
-<p><h1>head (0.16), (Rudolf)</h1></p>
+<p><h1>head (0.17), (Rudolf)</h1></p>
 <ul>
 	<li>Added AGP mode capability on AGP cards along with the option to block it in nv.settings. No GART and AGP aperture support; but if your card and system AGP host bridge support the 'fastwrite' (FW) feature, you'll notice a nice speedup of mostly unaccelerated graphics. Tested Quake 2 in software rendering mode over here using timedemo1 with demo1.dm2: framerates jumped up to 140% of the 'original' in 'just' AGP2.0 4X mode!<br>
 <strong>Note please :</strong> You need the new AGP kernel driver I setup for this feature, without it you will remain using PCI mode as usual. This AGP driver will be released seperately asap: it's almost ready.
 	<li>Updated CRTC memory granularity settings on TNT2 and later cards to reduce use of card internal bandwidth: this should minimize or prevent distortions on cards that have limited bandwidth available (especially on older cards). Note: doesn't actually fix the problem! (to be continued...)
 	<li>Updated CRTC modeline tuning for panels: this should fix the 'right-shifted' picture on some panels in their native modes;
-	<li>Fixed BIOS ROM dump (to file) option.
+	<li>Fixed BIOS ROM dump (to file) option;
+	<li>Fixed GET_TIMING_CONSTRAINTS and GET_ACCELERANT_DEVICE_INFO accelerant hooks to return valid data; updated modeline checking and modification code (used by ProposeDisplayMode) to adhere to one more timing constraint.
 </ul>
 <p><h1>nv_driver 0.10, (Rudolf)</h1></p>
 <ul>
diff --git a/src/add-ons/kernel/drivers/graphics/nvidia/driver.c b/src/add-ons/kernel/drivers/graphics/nvidia/driver.c
index 156404592e..3c1fda19b5 100644
--- a/src/add-ons/kernel/drivers/graphics/nvidia/driver.c
+++ b/src/add-ons/kernel/drivers/graphics/nvidia/driver.c
@@ -508,7 +508,12 @@ static status_t map_device(device_info *di)
 		di->pcii.bus, di->pcii.device, di->pcii.function);
 
 	/* disable ROM shadowing, we want the guaranteed exact contents of the chip */
-	set_pci(NVCFG_ROMSHADOW, 4, 0);
+	/* warning:
+	 * don't touch: (confirmed) NV04, NV05, NV05-M64, NV11 all shutoff otherwise.
+	 * NV18, NV28 and NV34 keep working.
+	 * confirmed NV28 and NV34 to use upper part of shadowed ROM for scratch purposes,
+	 * however the actual ROM content (so the used part) is intact (confirmed). */
+	//set_pci(NVCFG_ROMSHADOW, 4, 0);
 
 	/* enable ROM decoding - this is defined in the PCI standard */
 	tmpUlong = get_pci(PCI_rom_base, 4);
