i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Appearance: Use BString::SetToFormat instead of sprintf to create hex color.

Browse Source 
Fixes a GCC7 Werror about (potential) format overflow.
This commit is contained in:
Augustin Cavalier
2018-05-20 17:35:53 -04:00
parent 172c944a5b
commit fe3a28958a
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/preferences/appearance/ColorPreview.cpp
+4 -3
View File
@@ -17,6 +17,7 @@
#include <Bitmap.h> #include <Bitmap.h>
#include <Message.h> #include <Message.h>
#include <MessageRunner.h> #include <MessageRunner.h>
#include <String.h>
#include <View.h> #include <View.h>
#include <Window.h> #include <Window.h>
@@ -227,11 +228,11 @@ ColorPreview::SetMode(bool rectangle)
void void
ColorPreview::_DragColor(BPoint where) ColorPreview::_DragColor(BPoint where)
{ {
char hexString[7]; BString hexStr;
sprintf(hexString, "#%.2X%.2X%.2X", fColor.red, fColor.green, fColor.blue); hexStr.SetToFormat("#%.2X%.2X%.2X", fColor.red, fColor.green, fColor.blue);
BMessage message(B_PASTE); BMessage message(B_PASTE);
message.AddData("text/plain", B_MIME_TYPE, &hexString, sizeof(hexString)); message.AddData("text/plain", B_MIME_TYPE, hexStr.String(), hexStr.Length());
message.AddData("RGBColor", B_RGB_COLOR_TYPE, &fColor, sizeof(fColor)); message.AddData("RGBColor", B_RGB_COLOR_TYPE, &fColor, sizeof(fColor));
BRect rect(0.0f, 0.0f, 20.0f, 20.0f); BRect rect(0.0f, 0.0f, 20.0f, 20.0f);